Repository navigation
db: page account session discovery - #296
Merged
Merged
Conversation
samgbafa
added
rocinante.team=Naomi
Contributor
Author
|
Astra: APPROVE |
This was referenced Oct 15, 2026
samgbafa
added a commit
that referenced
this pull request
Oct 17, 2026
Review F1: on the first boot after 1.20.6, #291's CREATE TABLE delegation_cid_alias ... REFERENCES delegation runs before #296 and takes SHARE ROW EXCLUSIVE on delegation, so it still waited forever behind an open write transaction. Set SET LOCAL lock_timeout = '30s' once on the outer migrate() transaction, next to the TC-1054 statement_timeout exemption, so it covers every boot migration. Remove the per-migration SET LOCAL / TO DEFAULT from #296, which would have reset the outer setting for later migrations. Map 55P03 from anywhere in the migrations to a DbErr::Migration naming the lock wait; sea-orm-migration does not expose the failing migration's name in the error (its 'Applying migration' log line names it). Tests: from the 1.20.6 schema, an open write on delegation makes the boot fail at 30s with no migration applied or recorded and no lock_timeout left on the pooled session; after release the boot applies everything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs TC-1195
Keyset-page account session discovery by delegation ID and use an indexed cursor.